Repository navigation
fix: let antdv-next match every minor up to the next major - #1
Merged
Merged
Conversation
The shared range for antdv-next was pinned to major.minor, so a bundle built against antdv-next 1.5 declared ~1.5. NGINX UI 3.0 ships 1.7 and 3.0.2 ships 1.8, and the host's loader refused such bundles as incompatible: the official DNS-01 plugin's challenge form never loaded on any 3.0 release (0xJacky/nginx-ui#2113). Every routine minor upgrade of the host would do the same to every plugin. antdv-next now gets the same range as vue, vue-router and pinia: >=<built version> <<next major>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A library installed as a prerelease, such as antdv-next 1.9.0-beta.1, produced >=1.9.0-beta.1 <2. The host's range matcher does not accept a prerelease in a range, so the bundle was refused; the old ~1.9 range matched. The lower bound is now major.minor.patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The shared range for antdv-next was pinned to
major.minor. The DNS-01 plugin 1.0.0 was built against antdv-next 1.5.4 and declares~1.5; NGINX UI 3.0.0/3.0.1 ship antdv-next 1.7 and 3.0.2 ships 1.8. The host's loader (app/src/plugin/loader.ts) skips a bundle whose range does not match, so the plugin's challenge form, with its CNAME and propagation switches, never loaded on any 3.0 release (0xJacky/nginx-ui#2113). Every routine minor upgrade of antdv-next on the host would do the same to every plugin.Fix
antdv-next gets the same range as vue, vue-router and pinia:
>=<built version> <<next major>. README example updated.Tests
shared-rangetests fail onmain(Expected ">=1.5.4 <2",Received "~1.5") and pass here;bun test24 pass,typecheckandbuildclean.app/src/plugin/semver.ts) accepts>=1.5.4 <2for 1.5.4, 1.7.1 and 1.8.1 and rejects 1.5.3 and 2.0.0.The DNS-01 plugin needs a rebuild with the released SDK to pick this up.
🤖 Generated with Claude Code