feat(nextcloud): allow suspending the cron CronJob via values - #881
Merged
Merged
Conversation
The CronJob template renders no `spec.suspend`, so the field has no desired value in the manifest. Anything that reconciles the chart's output — ArgoCD, Flux, `helm diff` — has nothing to compare against, and a `kubectl patch ... suspend=true` therefore survives every subsequent sync while the release keeps reporting as in-sync. That is not hypothetical: we had `nextcloud-cron` suspended by hand during a debugging session and left that way for 40 days. ArgoCD reconciled the object repeatedly over that period and left the suspension in place, because server-side apply correctly treats `spec.suspend` as owned by the client that set it. No file scans, no trashbin/version expiry, no notification delivery and no federated sync ran in that window, and nothing surfaced it. Render `suspend` unconditionally, defaulting to false, so the field is always present and always owned by whatever applies the chart. This also makes suspending the job a first-class values option rather than something you have to reach around the chart to do. Default behaviour is unchanged: `suspend: false` is the CronJob API default, so existing releases render an explicit false where the field was previously omitted. Signed-off-by: Marek Jagielski <marek.jagielski@protonmail.com>
marekjagielski
force-pushed
the
feat/cronjob-suspend
branch
from
August 24, 2026 12:23
003418e to
691eb7c
Compare
wrenix
reviewed
Aug 25, 2026
wrenix
approved these changes
Aug 25, 2026
`values.yaml` already declares `cronjob.cronjob.suspend: false`, so the `| default false` pipeline in the template held a second copy of the same default that could never actually fire — Helm merges the chart defaults under any user-supplied values before the template runs. Drop it, matching the surrounding fields in the same block (`successfulJobsHistoryLimit`, `failedJobsHistoryLimit`), which read their values straight through. Rendering is unchanged: `suspend: false` by default, `suspend: true` with `--set cronjob.cronjob.suspend=true`. Signed-off-by: Marek Jagielski <marek.jagielski@protonmail.com>
Contributor
Author
|
Friendly ping — the Lint and Test Charts run for a78e2d8 is sitting in |
Signed-off-by: WrenIX <133280015+wrenix@users.noreply.github.com>
wrenix
enabled auto-merge (squash)
September 19, 2026 15:44
valeninki
pushed a commit
to valeninki/k8s
that referenced
this pull request
Sep 28, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [nextcloud](https://nextcloud.com/) ([source](https://github.com/nextcloud/helm)) | minor | `9.2.6` -> `9.3.0` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>nextcloud/helm (nextcloud)</summary> ### [`v9.3.0`](https://github.com/nextcloud/helm/releases/tag/nextcloud-9.3.0) [Compare Source](nextcloud/helm@nextcloud-9.2.7...nextcloud-9.3.0) A file sharing server that puts the control and security of your own data back into your hands. #### What's Changed - feat(nextcloud): allow suspending the cron CronJob via values by [@​marekjagielski](https://github.com/marekjagielski) in [#​881](nextcloud/helm#881) #### New Contributors - [@​marekjagielski](https://github.com/marekjagielski) made their first contribution in [#​881](nextcloud/helm#881) **Full Changelog**: <nextcloud/helm@nextcloud-9.2.7...nextcloud-9.3.0> ### [`v9.2.7`](https://github.com/nextcloud/helm/releases/tag/nextcloud-9.2.7) [Compare Source](nextcloud/helm@nextcloud-9.2.6...nextcloud-9.2.7) A file sharing server that puts the control and security of your own data back into your hands. #### What's Changed - chore(deps): bump helm/kind-action from 1.14.0 to 1.15.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​882](nextcloud/helm#882) - fix(nextcloud): update AppVersion to v34.0.4 by [@​promasu](https://github.com/promasu) in [#​884](nextcloud/helm#884) **Full Changelog**: <nextcloud/helm@nextcloud-9.2.6...nextcloud-9.2.7> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDAuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE0MC4xIiwidGFyZ2V0QnJhbmNoIjoiazBzIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsImhvbGQtc3RvcmFnZS1hdWRpdCIsIm5leHRjbG91ZCJdfQ==--> Reviewed-on: https://git.valentinus.dev/valeninki/k8s/pulls/8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Renders
spec.suspendon the cron CronJob unconditionally (defaulting tofalse), and exposes it ascronjob.cronjob.suspend.Benefits
The template currently renders no
spec.suspendat all, so the field has no desired value in the manifest. Anything that reconciles the chart's output — ArgoCD, Flux,helm diff— has nothing to compare against, and under server-side apply akubectl patch ... suspend=truetakes ownership of the field and survives every subsequent sync, while the release keeps reporting as in-sync.That is not hypothetical. We had
nextcloud-cronsuspended by hand during a debugging session and left that way for days. ArgoCD reconciled that very object repeatedly across the period and left the suspension in place — correctly, since it did not own the field. In that window Nextcloud ran no file scans, no trashbin/version expiry, no notification delivery, no federated sync and no app-update checks, and nothing surfaced it.managedFieldsshowedspec.suspendowned bykubectl-patch, never byargocd-controller.Rendering the field always puts it back under the chart's ownership, so a manual patch is reverted on the next sync instead of silently persisting. It also makes suspending the job a first-class values option rather than something you reach around the chart to do.
Possible drawbacks
None that I can find.
falseis already the CronJob API default, so behaviour is unchanged for every existing release — the only difference is that a previously-omitted field now renders as an explicitfalse. For users who deliberately suspend the job out-of-band today, that manual patch will now be reverted on the next chart apply; settingcronjob.cronjob.suspend: trueis the supported replacement, and arguably the point of the change.Applicable issues
None open that I could find — happy to file one first if you'd prefer that order.
Additional information
Verified against
charts/nextcloud:helm lint .— 1 chart linted, 0 failedhelm template .withcronjob.enabled=true cronjob.type=cronjob→suspend: false--set cronjob.cronjob.suspend=true→suspend: truecronjob.type=sidecarrenders no CronJob, unaffectedvalues.yamland the README values tableChart.yamlbumped 9.2.6 → 9.3.0 (minor: adds a value, no breaking change)Checklist
Chart.yamlaccording to semver.