Skip to content

fix: Add support for unified sharing - #10307

Open
nilsding wants to merge 148 commits into
masterfrom
feature/noid/unified-sharing
Open

fix: Add support for unified sharing#10307
nilsding wants to merge 148 commits into
masterfrom
feature/noid/unified-sharing

Conversation

@nilsding

@nilsding nilsding commented Jul 6, 2026 •
edited by claucambra
Loading

Copy link
Copy Markdown
Member
Screenshot 2026-08-13 at 23 08 19 Screenshot 2026-08-13 at 23 08 16 Screenshot 2026-08-13 at 23 08 12 Screenshot 2026-08-13 at 23 04 41 Screenshot 2026-08-13 at 23 04 32 Screenshot 2026-08-13 at 23 04 25

TODO

  • adapt to recent WIP API changes
  • clean up commits
  • add tests
  • make UI look nice, matching the new style used throughout recent additions (e.g. account wizard redesign, governance dialog)
  • integrate with File Provider UIExt

Checklist

AI (if applicable)

@nilsding nilsding self-assigned this Jul 6, 2026
@Rello Rello moved this to 🏁 NC34 in 💻 Desktop Clients team Jul 6, 2026
@nilsding
nilsding force-pushed the feature/noid/unified-sharing branch 3 times, most recently from 84fd68a to c93a4a3 Compare July 10, 2026 10:08
@nilsding nilsding mentioned this pull request Jul 10, 2026
Merged
10 tasks
@claucambra claucambra self-assigned this Jul 27, 2026
@claucambra claucambra added this to the 35.0.0 milestone Jul 27, 2026
@nilsding
nilsding force-pushed the feature/noid/unified-sharing branch from c93a4a3 to 2efe403 Compare July 28, 2026 07:15
@claucambra
claucambra force-pushed the feature/noid/unified-sharing branch 3 times, most recently from e5efeb2 to 54645cf Compare July 30, 2026 04:39
@claucambra
claucambra force-pushed the feature/noid/unified-sharing branch 2 times, most recently from be48328 to f0999ce Compare August 17, 2026 12:58
@claucambra claucambra changed the title draft: support for unified sharing fix: Add support for unified sharing Aug 17, 2026
@claucambra
claucambra marked this pull request as ready for review August 17, 2026 13:30
@claucambra
claucambra force-pushed the feature/noid/unified-sharing branch 3 times, most recently from 679e9d1 to 3cc85a9 Compare August 18, 2026 05:05
@Rello Rello moved this from 🏁 NC34 to NC35 in 💻 Desktop Clients team Aug 18, 2026
@claucambra
claucambra force-pushed the feature/noid/unified-sharing branch 5 times, most recently from 5075cf9 to 52a41b3 Compare August 18, 2026 14:30
@claucambra
fix(file-provider): Only present sharing entry in context menu when e…
2513995 
…xactly one item selected

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(file-provider): Better handle single-item condition for sharing t…
89c0569 
…rigger

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Remove unneeded pragma in sharedetailspage
12fd3df 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Generate permission preset label from cpp side
aea5e0a 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Use model testers in testunifiedsharing
31fe735 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Extract share details frame from share dialog
8558c77 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Controller reference in sharedialog
0ee941a 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Fix share dialog instantiation and test it
9165440 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Add toggle switches to optional fields
736b8aa 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Dialog layout and detail setup
e92f124 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Address scrollbar and footer visibility issues
fdf07e2 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Move advanced properties into separate page
b663ca4 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Add delete button onto share delegates
ad10be9 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Match settings panel switch design
854ad23 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Remove sections for shares
998473d 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Remove advanced settings header
9f19ae3 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Display YYYY-MM-DD instead of cryptic ISO-8601
6743459 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Use rounded avatar images
64e2bd6 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Increase share inter-item spacing
ba62bf6 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Use multiline text field for notes to recipients
e653b52 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Add top padding above text field
7877601 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Restore back.svg
d7fc4d5 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Simplify switch UI handling
af03bf2 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Switch delegate backgrounds
0fdcef2 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Use person_add icon as share fallback
629f48d 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
fix(sharing): Rounded avatar images
90aaa0e 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
claucambra force-pushed the feature/noid/unified-sharing branch from fe82e1f to 8ef07bf Compare September 1, 2026 13:37
@claucambra
fix(sharing): Adapt to QT_NO_KEYWORDS
4413cd3 
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra
claucambra force-pushed the feature/noid/unified-sharing branch from 8ef07bf to 4413cd3 Compare September 1, 2026 14:24
kra-mo
kra-mo approved these changes Sep 3, 2026
View reviewed changes

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, although I'd still prefer if the switches looked consistent with settings, so like this:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claucambra claucambra claucambra left review comments
@kra-mo kra-mo kra-mo approved these changes
@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner
@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner
@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner
@nimishavijay nimishavijay Awaiting requested review from nimishavijay

At least 1 approving review is required to merge this pull request.

Assignees

@nilsding nilsding

@claucambra claucambra

Labels

None yet

Projects

💻 Desktop Clients team
Status: NC35
🖍 Design team
Status: 🏗️ At engineering

Milestone

35.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nilsding @claucambra @kra-mo @jancborchardt @Rello