Repository navigation
Conversation
Only the final ReadString(strLongSha256) call was checked before, so malformed packets with invalid intermediate string lengths or truncated reads could still pass Read() and forward misaligned SModInfoItem data to onPlayerModInfo. Check each BitStream read inside the item loop, reset packet state cleanly on entry/failure, and initialize primitive fields in SModInfoItem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check every
BitStreamread inside the item loop inCPlayerModInfoPacket::Read, clearm_strInfoTypeandm_ModInfoItemListon entry/failure, and default-initialize the primitive fields inSModInfoItem.Motivation
Previously only the final
ReadString(item.strLongSha256)return value was checked. Malformed packets with invalid intermediate string lengths (leaving trailing bytes unread) or truncated reads could still passRead()and forward partial or misalignedSModInfoItemdata toonPlayerModInfo.Test plan
Built
Deathmatch(Release Win32) with no warnings in the modified files, verified formatting withclang-format, and tested valid round-trips plus malformed/truncated payload rejection usingMockBitStream.Checklist