Repository navigation
Fix crash when loading/unloading truncated IFP files - #5559
Closed
MohabCodeX wants to merge 2 commits into
Closed
MohabCodeX wants to merge 2 commits into
MohabCodeX wants to merge 2 commits into
Conversation
Guard against null hierarchy and sequence pointers in CIFPAnimations::DeleteAnimations() to avoid crash on disconnect when cleaning up malformed or truncated IFPs. Switch CClientIFP from premature vector resizing to safe reserve and push_back with remaining buffer bounds checks, and emit a debugscript warning if loaded animations count is less than declared in the header. Also guard CClientIFP::GetAnimationHierarchy() against null hierarchy pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a client crash that occurs when loading malformed or truncated custom IFP files and during cleanup on disconnect.