Repository navigation
Prevent silent crashes and improve crash dialog reliability - #5441
Open
MohabCodeX wants to merge 4 commits into
Open
MohabCodeX wants to merge 4 commits into
MohabCodeX wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR aims to prevent silent crashes where MTA:SA unexpectedly closes without showing the crash dialog or saving diagnostic logs. On 64-bit Windows running a 32-bit process, exceptions that occur inside window procedures and message callbacks are swallowed by default under WOW64, causing the game to exit silently before reaching our unhandled exception filter; calling SetProcessUserModeExceptionPolicy with 0 ensures these exceptions properly propagate so the crash handler can capture them. In addition, the crash dialog is now located using the spawned process ID instead of relying on a hardcoded English window title (which previously caused silent timeouts on non-English locales), memory inspections during dump generation are wrapped in SEH to prevent secondary crashes while writing dumps, and an emergency in-process message box fallback was added in case the external crash tool fails to launch.