Email the requester when a UI-launched run finishes - #6869
ayoubdiourin7 wants to merge 13 commits into
Conversation
| run.agent, | ||
| ) | ||
| await pubsub.publish_run_completed(str(run.run_id), run.agent, run.status) | ||
| await notifications.notify_requester(run) |
There was a problem hiding this comment.
This should be in the internal API that receives the "run completed" events.
| ui_base_url: str = "http://localhost:3000" | ||
| sendgrid_api_key: str = "" | ||
| notification_sender: str = "" | ||
| notification_override_email: str = "" |
There was a problem hiding this comment.
Why we need notification_override_email?
There was a problem hiding this comment.
It’s for testing. It redirects emails to a test inbox so we can verify that notifications work correctly.
|
|
||
| def build_message(run: Run) -> tuple[str, str]: | ||
| """Compose the subject and Markdown body of the notice for ``run``.""" | ||
| outcome = run.status.replace("_", " ") |
There was a problem hiding this comment.
I would mention the first part of the run ID, similar to the UI. If there is a bug id, I would mention it here.
| recipient = _recipient(run) | ||
| subject, body = build_message(run) | ||
| try: | ||
| status_code = await asyncio.to_thread(_send_sync, recipient, subject, body) |
There was a problem hiding this comment.
Can we have a native way to send async?
There was a problem hiding this comment.
I checked, and SendGrid’s Python SDK doesn’t support native async sending.
| if not run.requested_by: | ||
| return False |
There was a problem hiding this comment.
We should file an issue to have a proper why to identify it was triggered by the UI (that issue would be blocked by #6724). That issue should be referenced here.
2 participants
Fixes #6866