Skip to content

Clarify concise Phabricator patch descriptions #6834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayoubdiourin7 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Open

Clarify concise Phabricator patch descriptions #6834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions libs/hackbot-runtime/hackbot_runtime/actions/phabricator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,22 @@ async def submit_patch(
],
test_plan: Annotated[
str | None,
Field(default=None, description="Revision test plan."),
Field(
default=None,
description=(
"Keep the revision test plan concise. Do not include detailed logs "
"or narrate the verification process."
),
),
] = None,
summary: Annotated[
str | None,
Field(
default=None,
description=(
"Revision summary/description. Keep test and verification details "
"in test_plan instead."
"Keep the revision summary concise and useful for permanent history. "
"Do not restate the bug, narrate the investigation or implementation "
"process, or include test and verification details."
),
),
] = None,
Expand Down