Skip to content

Bug 2084149 - #2832

Merged
dklawren merged 2 commits into
mozilla:masterfrom
dklawren:2084149
Nov 18, 2026
Merged

dklawren merged 2 commits into
mozilla:masterfrom
dklawren:2084149

Conversation

@dklawren

Copy link
Copy Markdown
Collaborator

Review+ carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2084149

Copilot AI balanced review requested due to automatic review settings November 18, 2026 21:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the changes that filter inaccessible bugs before duplicate-search result limits.

No open issues 🎉

What changed in this PR

Addresses Bug 2084149 by filtering inaccessible bugs before possible-duplicate result limits, preventing hidden summary matches from consuming result slots.

Changes:

  • Adds a SQL visibility predicate matching existing bug-access rules.
  • Filters search candidates before SQL limiting and resolved duplicate targets before final truncation.
  • Adds REST regression tests for privileged, CC-only, and anonymous users, including boolean-mode probes; SQL-cutoff coverage still needs six higher-ranked hidden candidates.
File Description
qa/​t/​rest_bug_possible_duplicates.t Adds regression tests for restricted-summary privacy and privileged, CC-only, and anonymous visibility in possible-duplicate searches.
Bugzilla/​User.pm Adds and documents visible_bugs_sql to express bug-visibility rules as a SQL predicate.
Bugzilla/​Bug.pm Applies visibility filtering before SQL limiting and checks resolved duplicate targets before final result truncation.

Review effort: Balanced

@dklawren
dklawren merged commit 3569a6c into mozilla:master Nov 18, 2026
7 checks passed
@dklawren
dklawren deleted the 2084149 branch November 18, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants