Skip to content

Bug 2094200 - [MENTIONS] Make the banner bigger for needinfo mentions so it is more noticable - #2831

Merged
dklawren merged 3 commits into
mozilla:masterfrom
dklawren:2094200
Nov 18, 2026
Merged

dklawren merged 3 commits into
mozilla:masterfrom
dklawren:2094200

Conversation

@dklawren

Copy link
Copy Markdown
Collaborator
image

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the mention-warning styling and needinfo emphasis changes.

No open issues 🎉

What changed in this PR

Makes the comment editor’s mention warning more noticeable, with a larger banner and stronger emphasis on needinfo requests.

Changes:

  • Increases banner spacing, border prominence, and font size, with added spacing between warning paragraphs.
  • Bolds the needinfo heading while preserving HTML encoding.
File Description
skins/​standard/​text-editor.css Enlarges the mention warning and adds paragraph spacing.
js/​text-editor.js Emphasizes the needinfo heading with bold markup.

Review effort: Balanced

@dklawren
dklawren requested review from Xzzz and cgsheeh November 17, 2026 19:52

@Xzzz Xzzz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the bold title and larger box make the needinfo warning much more visible, have to say. Thank you! :)

@dklawren
dklawren merged commit 9fb3ecb into mozilla:master Nov 18, 2026
7 checks passed
@dklawren
dklawren deleted the 2094200 branch November 18, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants