Repository navigation
certora: remove munging - #125
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
MathisGD
reviewed
Nov 19, 2026
MathisGD
previously approved these changes
Nov 19, 2026
QGarchery
reviewed
Nov 19, 2026
QGarchery
previously approved these changes
Nov 20, 2026
QGarchery
approved these changes
Nov 20, 2026
MathisGD
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Certora now verifies
src/directly, so the munging step is gone. Before this PR, the only thing the munge did was add a_zeroVirtualVotingPowervariable (the voting power of address zero) to the token contracts.A CVL ghost now does that job.
zeroVirtualVotingPower[x]is the partial sum, over accounts< x, of the balances of accounts whose delegatee isaddress(0). The existing_balancesand_delegateeSstorehooks inERC20Invariants.speckeep it updated. The specs readzeroVirtualVotingPower[2^160]wherever they used to readcurrentContract._zeroVirtualVotingPower.New invariants
zeroVirtualVotingPowerStartsAtZero,zeroVirtualVotingPowerGrowsCorrectlyandzeroVirtualVotingPowerMonotoneprove that the ghost is consistent and nonnegative.totalSupplyIsSumOfVirtualVotingPowerrelies on them, and also on the already-provenzeroAddressNoVotingPower,totalSupplyIsSumOfBalancesandbalancesLTEqTotalSupplyin itsinitializepreserved block.Removed:
certora/Makefile,applyMunging.patch, the munging CI step, the.gitignoreentry and the README mention. Harnesses now import fromsrc/.src/itself is unchanged.All 8 affected confs pass with
rule_sanity: basic, run locally: DelegationEthereum, DelegationOptimism, MintBurnEthereum, MintBurnOptimism, ERC20InvariantsEthereum, ERC20InvariantsOptimism, ERC20Ethereum, ERC20Optimism.Link to Devin session: https://app.devin.ai/sessions/23d117fa4e4342efa198c5b4e90e403e
Open in Devin Desktop: https://app.devin.ai/desktop/session/23d117fa4e4342efa198c5b4e90e403e?variant=devin
🟢 Devin Review found nothing to fix · View findings