Add the v2-qbzd renderer plugin for Qobuz Connect - #1
Open
Gjuju wants to merge 1 commit into
Open
Conversation
Same shape as v8-librespot: the renderer config button hands the job to plugin-updater.sh, which fetches this zip, clones pkgbuild, runs the qbzd recipe on the host and installs the resulting .deb. One difference from the librespot script it is modelled on: the cp that brings the .deb out of dist/binary is checked. It was the only unchecked step of the chain -- the build before it and the apt after it both are. When the build failed, that cp failed silently and apt installed whatever qbzd_*.deb was left in /tmp from an earlier run, so the updater reported "Update installed, restart required" over a build that had compiled nothing. v8-librespot carries the same unchecked cp. Verified end to end on an Orange Pi 3 LTS and a Raspberry Pi 3B, from a box with no qbzd package installed: 439 and 430 crates compiled, package installed, binary reporting 2.0.2.moode49. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same shape as v8-librespot: renderer config hands the job to
plugin-updater.sh, which fetches this zip, clones pkgbuild, runs the qbzd
recipe on the host and installs the resulting .deb.
Depends on moode-player/pkgbuild#NNN -- this script runs
packages/qbzd/build.sh, which does not exist there yet.
One deliberate difference from the librespot script: the cp that brings the
.deb out of dist/binary is checked. It was the only unchecked step -- the build
before it and the apt after it both are. When the build failed, that cp failed
silently and apt installed whatever qbzd_*.deb was left in /tmp from an earlier
run, so the updater reported "Update installed, restart required" over a build
that had compiled nothing. v8-librespot carries the same unchecked cp.
Verified end to end on an Orange Pi 3 LTS and a Raspberry Pi 3B.