Conversation
Artanias
reviewed
Sep 15, 2026
Comment on lines
+23
to
+38
| DEFAULT_CONNECTIONS: list[dict[str, str | int | bool]] = [ | ||
| { | ||
| "name": "yocto", | ||
| "host": "10.5.0.10", | ||
| "user": "root", | ||
| "password": "", | ||
| "port": 2222, | ||
| }, | ||
| { | ||
| "name": "opensuse", | ||
| "host": "10.5.0.13", | ||
| "user": "suser", | ||
| "password": "password", | ||
| "port": 1616, | ||
| }, | ||
| ] |
Collaborator
There was a problem hiding this comment.
Надо бы также из переменных окружения доставать host, user, password, port (с помощью env_var_to_type) и определять данный список только при наличии их (переменных окружения).
Artanias
reviewed
Sep 15, 2026
| @@ -282,16 +269,16 @@ def download(self, remotepath: Path, localpath: Path) -> ExecResult: | |||
|
|
|||
|
|
|||
| def wait_remote( | |||
Collaborator
There was a problem hiding this comment.
Ещё бы подтянуть изменения из main, там теперь возможно задавать путь до приватного ключа.
Artanias
reviewed
Sep 15, 2026
| name: Mapped[str] = mapped_column(String(100), unique=True) | ||
| host: Mapped[str] = mapped_column(String(100)) | ||
| user: Mapped[str] = mapped_column(String(100)) | ||
| password: Mapped[str] = mapped_column(String(100)) |
Collaborator
There was a problem hiding this comment.
Ещё бы добавить путь до приватного ключа, чтобы была возможность безболезненно на них перейти и не хранить пароли в БД.
Artanias
reviewed
Sep 15, 2026
| port: Mapped[int] = mapped_column(Integer) | ||
| is_active: Mapped[bool] = mapped_column(Boolean, server_default="true") | ||
|
|
||
| def __repr__(self) -> str: |
Collaborator
There was a problem hiding this comment.
Обычно пишется так, чтобы по этой строке можно было точно воссоздать объект в коде, т.е. не хватает остальных полей.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.