Conversation
AHaumer
added
enhancement
beutlich
reviewed
Jun 8, 2022
beutlich
left a comment
beutlich
left a comment
Member
There was a problem hiding this comment.
Just a quick spelling check.
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
Co-authored-by: Thomas Beutlich <modelica@tbeu.de>
AHaumer
enabled auto-merge
June 9, 2022 05:03
beutlich
removed their request for review
June 9, 2022 19:43
This reverts commit ea740a58823b9ce65f6b54d94a1208dfe7159f98.
dietmarw
approved these changes
Jun 13, 2022
Member
There was a problem hiding this comment.
@AHaumer I had to revert your "???" commit once again. Please follow the instruction I gave you of basing your future PRs on the current master (rather than keeping to merge the current master into your "broken" local master with that "???" commit).
Otherwise, it looks good.
beutlich
disabled auto-merge
June 13, 2022 08:19
beutlich
enabled auto-merge (squash)
June 13, 2022 08:20
beutlich
removed their request for review
September 24, 2022 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recognized that modeling of permanent magnets in electrcal machines would need some explanations.