Skip to content

Allow FastMCP SSE servers to exit cleanly on SIGINT after serving traffic - #3564

Closed
00200200 wants to merge 1 commit into
modelcontextprotocol:mainfrom
00200200:fix/sse-shutdown-close-streams
Closed

00200200 wants to merge 1 commit into
modelcontextprotocol:mainfrom
00200200:fix/sse-shutdown-close-streams

Conversation

@00200200

Copy link
Copy Markdown

Summary

  • Add SseServerTransport.close() to end active SSE/read streams.
  • Wire SSE Starlette lifespan to call close() on shutdown so uvicorn is not stuck waiting on open EventSourceResponse tasks.

Fixes #514

Test plan

  • uv run pytest tests/shared/test_sse.py::test_sse_transport_close_unblocks_active_session

Track per-session SSE writers and close them from the SSE app
lifespan so SIGINT after traffic can finish EventSourceResponse
tasks and exit cleanly.
@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Sep 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #514.

If a maintainer assigns you to #514, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FastMCP server with SSE transport fails to shut down on a signal

1 participant