Conversation
Track per-session SSE writers and close them from the SSE app lifespan so SIGINT after traffic can finish EventSourceResponse tasks and exit cleanly.
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #514. If a maintainer assigns you to #514, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
SseServerTransport.close()to end active SSE/read streams.close()on shutdown so uvicorn is not stuck waiting on open EventSourceResponse tasks.Fixes #514
Test plan
uv run pytest tests/shared/test_sse.py::test_sse_transport_close_unblocks_active_session