You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Require Duration::from_secs to return zero subsecond nanoseconds.
Keep the standard-library implementation unchanged.
Motivation
The current contract guarantees that the result is representation-safe and that its secs field equals the input, but it does not constrain the fractional component. An implementation can therefore preserve secs, add any valid number of nanoseconds, and still satisfy the contract.
The new clause captures the documented whole-seconds semantics:
The mutation kill rate increases from 0/3 to 3/3. The contract harnesses use unconstrained u64 inputs, no kani::assume, and a separate cover check reaches u64::MAX.
Note: reviewed as part of Ch9 triage. This PR is a narrow but sound contract hardening (adds #[ensures(|d| d.nanos.as_inner() == 0)] to Duration::from_secs), not a Ch9 solution attempt (Ch9 is already marked Resolved). No cfg body swaps, no runtime logic changes, non-vacuous ensures, and covered symbolically by the existing autoharness allowlist for time::Duration::from_secs (with --default-unwind 1000). Good followup direction: matching hardening for from_millis/from_micros/from_nanos. When ready to un-draft this can land as a hardening PR.
Thanks for the review. This PR is already ready for review (marked ready on August 29). I rechecked the current head, 6a3c8e3: 26 checks pass, with two skipped. The diff remains the single from_secs postcondition, with no runtime changes.
I agree that this is contract hardening rather than a Ch9 solution. The matching constructors would be a separate follow-up so this PR stays focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duration::from_secsto return zero subsecond nanoseconds.Motivation
The current contract guarantees that the result is representation-safe and that its
secsfield equals the input, but it does not constrain the fractional component. An implementation can therefore preservesecs, add any valid number of nanoseconds, and still satisfy the contract.The new clause captures the documented whole-seconds semantics:
#[ensures(|duration| duration.nanos.as_inner() == 0)]Mutation evidence
The mutation kill rate increases from 0/3 to 3/3. The contract harnesses use unconstrained
u64inputs, nokani::assume, and a separate cover check reachesu64::MAX.Validation
MUTATION_MATRIX=PASSresult.nanos == 0cargo fmt --check: passedgit diff --check: passedThe production diff is contract-only and adds no precondition or runtime behavior change.
Related to the contract-strength discussion in #630.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.