Repository navigation
Conversation
Provide the char-pointer-returning __gnu_strerror_r symbol required by newer Android libraries without changing the existing POSIX strerror_r mapping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 95f0e7b4-09d5-46e2-94d4-26475809d4c2
|
Beat me to it. I've tested my own solution which is functionally equivalent, so this should be good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Minecraft 1.26.60.4 fails to load libpairipcore.so because the Android libc shim does not expose __gnu_strerror_r. The client then exits with signal 11.
Change
Register __gnu_strerror_r on glibc hosts using the native GNU strerror_r implementation and the existing Android-to-host errno translation. Preserve its char* return value: the existing shim::strerror_r has a POSIX int return value and cannot be used as an alias. Non-glibc builds and the existing strerror_r registration are unchanged.
Validation
Related: minecraft-linux/mcpelauncher-manifest#2092, minecraft-linux/mcpelauncher-manifest#2095, minecraft-linux/mcpelauncher-manifest#2084.
The launcher manifest will also need to update its libc-shim submodule after this is merged.