Skip to content

fix: preserve PowerShell argument arrays - #1092

Open
nightcityblade wants to merge 1 commit into
microsoft:mainfrom
nightcityblade:fix/issue-1024
Open

fix: preserve PowerShell argument arrays#1092
nightcityblade wants to merge 1 commit into
microsoft:mainfrom
nightcityblade:fix/issue-1024

Conversation

@nightcityblade

Copy link
Copy Markdown

Fixes #1024

Summary

  • splat PowerShell argument arrays when launching debugpy
  • preserve each debug target argument as a separate process argument on Windows and Unix-like platforms

Validation

  • npm run pretest
  • full extension unit suite: 588 passing, 27 pending
  • PowerShell parser validation
  • end-to-end launcher check confirmed arg1 and arg2 remain separate

@rchiodo

Copy link
Copy Markdown
Contributor

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

@rchiodo

Copy link
Copy Markdown
Contributor

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: Verification could not run because no trusted sandbox image is configured and local execution was not authorized. Static inspection confirmed the PowerShell `$args` splatting change and found no direct launcher argument-preservation test. Confidence is limited without executable validation.

Test runs: 1 not run

  • ⚠️ Not run | Repository test discovery | git status --short && git branch --show-current && git diff --name-status upstream/main...HEAD && git diff --unified=40 upstream/main...HEAD -- bundled/scripts/noConfigScripts/debugpy.ps1 && node -e "const p=require('./package.json'); console.log(JSON.stringify(p.scripts,null,2))" && rg -n --glob "test" --glob ".ts" --glob ".ps1" "debugpy.ps1|noConfigScripts|BUNDLED_DEBUGPY_PATH|wait-for-client" .
⚠️ Repository test discovery diagnostic output
Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python-debugger, and local execution was not authorized.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Aug 27, 2026
@nightcityblade

Copy link
Copy Markdown
Author

The code, test, lint, and CodeQL checks are green. The remaining Ensure Required Labels check requires exactly one of bug, debt, feature-request, or no-changelog; this PR fixes the argument-handling bug in #1024, but I do not have permission to apply the bug label. Could a maintainer add it when convenient?

@nightcityblade

Copy link
Copy Markdown
Author

The code, lint, test, CodeQL, CLA, and automated review checks have passed. The remaining Ensure Required Labels job fails because exactly one classification label is required; this PR currently only has review-auto:approved. Could a maintainer please add the bug label for this PowerShell argument-array fix? I do not have label permissions in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerShell script debugpy.ps1 incorrectly handles multiple arguments passed as an array

2 participants