Retry review comments with smaller pages - #8890
Open
Tamir Duberstein (tamird) wants to merge 1 commit into
Open
Conversation
Tamir Duberstein (tamird)
marked this pull request as ready for review
August 20, 2026 21:14
Contributor
Author
|
human here: confirmed without these changes i am unable to fetch review comments; with these changes, review comments reappear |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves resilience when refreshing PR review threads by making the GraphQL review-thread pagination adaptive: it keeps the normal 20-thread page size, but on HTTP 502 retries the same cursor with smaller pages (5 then 1) and continues fetching subsequent pages at the reduced size. It also preserves original variables when falling back to the legacy query unless explicit replacement variables are provided.
Changes:
- Add adaptive paging + retry-on-502 logic for fetching review threads, preserving cursors across retries.
- Update shared GraphQL queries to accept a
firstpage-size variable for both current and legacy review-thread queries. - Add regression tests covering cursor retention, retry exhaustion behavior, and legacy-fallback variable preservation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/github/pullRequestModel.ts | Implements 502-only retry with progressive page-size reduction while preserving cursors. |
| src/github/githubRepository.ts | Preserves original variables when executing a legacy fallback unless replacements are explicitly provided. |
| src/github/queriesShared.gql | Adds $first to PullRequestComments and LegacyPullRequestComments and uses it in reviewThreads(first: ...). |
| src/test/github/pullRequestModel.test.ts | Adds tests for retry behavior, page-size reduction, and cursor retention across retries. |
| src/test/github/githubRepository.test.ts | Adds tests ensuring legacy fallback uses original variables unless replacements are supplied. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Tamir Duberstein (tamird)
force-pushed
the
fix/review-comment-502
branch
from
August 20, 2026 21:51
4df848f to
1b8afc3
Compare
Contributor
Author
|
Dirk Bäumer (@dbaeumer) Alex Ross (@alexr00) could you kindly have a look at this? |
Tamir Duberstein (tamird)
force-pushed
the
fix/review-comment-502
branch
from
August 28, 2026 15:35
1b8afc3 to
24f9d71
Compare
Tamir Duberstein (tamird)
force-pushed
the
fix/review-comment-502
branch
from
August 28, 2026 16:31
24f9d71 to
f70dc3e
Compare
GitHub can return an HTML 502 response for a review-thread query that succeeds when fewer threads are requested. The fixed page size makes the entire refresh fail, including pages already fetched. Retain the normal 20-thread page from e0e7627. On HTTP 502, retry the same cursor with five threads and then one, retaining the smaller size for later pages. Stop reducing at one and leave other errors alone. Both current and legacy queries accept the page size, preserving the legacy pagination added by 5523166. Cover cursor retention, retry exhaustion, non-502 failures, and reduced page sizes through the legacy query.
Tamir Duberstein (tamird)
force-pushed
the
fix/review-comment-502
branch
from
September 1, 2026 18:01
f70dc3e to
aa1583a
Compare
Contributor
Author
|
This is ready for review! |
Copilot started reviewing on behalf of
Tamir Duberstein (tamird)
September 1, 2026 18:02
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub can return an HTML 502 response for a review-thread query that succeeds when fewer threads are requested. The fixed page size makes the entire refresh fail, including pages already fetched.
Retain the normal 20-thread page from e0e7627. On HTTP 502, retry the same cursor with five threads and then one, retaining the smaller size for later pages. Stop reducing at one and leave other errors alone. Both current and legacy queries receive the page size and cursor, preserving the legacy pagination added by 5523166. Regression coverage protects cursor retention, retry exhaustion, non-502 failures, and reduced page sizes through the legacy query.
Prepared with Codex.