-
Notifications
You must be signed in to change notification settings - Fork 91
feat(open): add 'open vscode' and 'open ssms', remove retired 'open ads' #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
David Levy (dlevy-msft-sql)
wants to merge
71
commits into
microsoft:main
Choose a base branch
from
dlevy-msft-sql:pr-685
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13,802
−8,571
Open
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
69f2e32
feat(open): add sqlcmd open vscode and sqlcmd open ssms commands
dlevy-msft-sql 5cf8ad9
fix: handle JSONC in VS Code settings.json and use atomic write
dlevy-msft-sql 0ee752c
fix: prevent TestVSCode from writing to real settings.json
dlevy-msft-sql 759dd91
fix: suppress errcheck lint for best-effort os.Remove on cleanup paths
dlevy-msft-sql 992947a
fix: RunWithOutput stdout conflict and clipboard security warning
dlevy-msft-sql 642aee4
i18n: localize Linux clipboard fallback error
dlevy-msft-sql 3fe54df
feat: remove sqlcmd open ads (Azure Data Studio retired)
dlevy-msft-sql f377082
feat(open): launch SSMS via ssms:// URL handler with registry-based d…
dlevy-msft-sql 1974251
revert: launch SSMS via ssms:// URL handler
dlevy-msft-sql 932d9fc
feat(open): discover SSMS via vswhere and add --version flag
dlevy-msft-sql 1ad7d48
feat(open): add --build flag and build-aware VS Code discovery
dlevy-msft-sql 59899f5
fix(tools): include exe name as argv[0] on Windows so first flag is n…
dlevy-msft-sql c2cc250
fix(tools): launch tools detached so sqlcmd returns immediately
dlevy-msft-sql 8899d6f
fix(open): connect via mssql --open-url instead of opening empty window
dlevy-msft-sql 6cbd13b
fix(tools): redirect gui child stdio to null device so sqlcmd exits
dlevy-msft-sql b8ff423
feat(open): finalize vscode launch for mssql extension
dlevy-msft-sql 7854f08
fix(open): satisfy golangci-lint (errcheck, QF1007)
dlevy-msft-sql 703aa92
fix(open): return empty string when container inspect fails
dlevy-msft-sql 4e251b5
fix(open): use Mandatory encrypt enum and honor VSCODE_EXTENSIONS
dlevy-msft-sql d22cba4
refactor(open): drop ai-slop comments and tautological clipboard tests
dlevy-msft-sql eba3f16
fix(tools): launch macOS vscode via in-bundle binary not the .app dir…
dlevy-msft-sql 4d21c4f
fix(open): pass ssms username argv raw without bogus shell-escape
dlevy-msft-sql 3cfb01d
fix(open): back up settings.json when vscode comments would be lost
dlevy-msft-sql 019b59c
refactor(open): drop dead vscode RunWithOutput and tautological tests
dlevy-msft-sql 3b318e2
revert: keep macOS vscode searchLocations on the .app bundle
dlevy-msft-sql 4a48da5
fix(open): don't claim mssql extension install succeeded when we only…
dlevy-msft-sql bff614f
fix(tools): detach stdio when /dev/null open fails to avoid pipe-drai…
dlevy-msft-sql b570c12
test(open): assert full settings.json path tail per OS not just Code
dlevy-msft-sql 4c4ada0
refactor(open): drop --install-extension; vscode:// URL already prompts
dlevy-msft-sql 526da86
docs: address PR feedback on open vscode/ssms
dlevy-msft-sql 337f562
refactor(tools): drop unused RunWithOutput and stale --install-extens…
dlevy-msft-sql 398fb72
fix(i18n): restore translation catalog after rebase
dlevy-msft-sql b7d00e0
fix(open): drop tcp: prefix and base64-encode test password
dlevy-msft-sql f54a3ee
feat(open): platform-conditional vscode/ssms hints in help
dlevy-msft-sql 7d60dc0
test(ssms): cover partial-install case; drop trivial Name() test
dlevy-msft-sql b1ceef5
refactor(open): preserve vscode settings.json comments via hujson
dlevy-msft-sql de68315
feat(open): enable 'sqlcmd open' on linux
dlevy-msft-sql 3a0f060
refactor(root): drop tautological GOOS gate on open subcommand
dlevy-msft-sql 7d8e49b
fix(open): resolve vscode settings path for snap, XDG, and missing HOME
dlevy-msft-sql b5a7e51
fix(open): scope persisted credentials and clipboard copy to the inst…
dlevy-msft-sql bb25b99
fix: address copilot review on PR #688
dlevy-msft-sql 8de3474
chore: remove accidentally committed scratch files
dlevy-msft-sql 858bdc7
fix(container): return empty string when ContainerName called with em…
dlevy-msft-sql 7da4284
fix(open): use platform-appropriate home-dir hint
dlevy-msft-sql 46d2c39
fix: address copilot review on basic auth guard and ssms help text
dlevy-msft-sql d5649e4
fix: localize home directory error and ssms_unix fatal message
dlevy-msft-sql 061c494
fix: address copilot review on argv normalization, home dir nil err, …
dlevy-msft-sql a0d890f
refactor: hoist ssms struct and DefineCommand to untagged file
dlevy-msft-sql 370dad1
fix: verify vscode install before writing settings; harden code shim …
dlevy-msft-sql 4f5219f
refactor: rename Ssms type to SSMS for acronym consistency
dlevy-msft-sql 5dad958
fix: detect early-exit failures in tool.Run and show SSMS install help
dlevy-msft-sql 6363710
fix: guard copyPasswordToClipboard against nil output
dlevy-msft-sql f087a31
test: gate COMSPEC-based tool tests to Windows
dlevy-msft-sql 7b90192
docs: update tool.Run stdio comment to match Wait goroutine
dlevy-msft-sql d609275
fix: restrict isLocalEndpoint to container-backed endpoints
dlevy-msft-sql 39b14e5
fix: drop redundant port field from vscode mssql profile
dlevy-msft-sql 934a58d
fix: resolve clip.exe via SystemRoot to avoid PATH hijack
dlevy-msft-sql 6bd9f17
fix: clean up vscode connection profile when sqlcmd delete runs
dlevy-msft-sql 2a488ed
fix: harden Windows path fallbacks for clip.exe and VS Code probing
dlevy-msft-sql dfe38f9
fix(open): fail fast on 'open vscode' and 'open ssms' with no current…
dlevy-msft-sql 7b42463
fix(open): guard linux/darwin VS Code probes against empty HOME
dlevy-msft-sql 4cbea7d
refactor: drop restate-the-code comments from open/clipboard files
dlevy-msft-sql f9348bb
feat: stage password to clipboard for VS Code remote SQL auth
dlevy-msft-sql 904c306
test: reset shared config between open tests to make them order-indep…
dlevy-msft-sql 329fc50
fix: harden vscode settings dir perms, pin pbcopy path, isolate more …
dlevy-msft-sql 8593451
fix: pin linux clipboard helper to LookPath result to prevent PATH races
dlevy-msft-sql 4e2a655
fix: suggest install options when linux clipboard helper is missing
dlevy-msft-sql e7e743f
fix: list per-WM install commands in linux clipboard error
dlevy-msft-sql 76adf78
fix(open vscode): launch via in-bundle code CLI on macOS
dlevy-msft-sql 654d381
fix(config add-endpoint): don't apply locale thousands separator to port
dlevy-msft-sql d8110b3
refactor(open): trim restate-the-code and dramatic comments
dlevy-msft-sql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.