Update URL & interface to accept Location XMLHttpRequest - #2552
Update URL & interface to accept Location XMLHttpRequest#2552Adam Naji (Bashamega) wants to merge 5 commits into
Conversation
…ds across multiple baselines
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
|
Should i handle the fallback to WorkerLocation in the emitter or what should i do in this situation? |
| method parse signatureIndex=0 { | ||
| param base overrideType="string | URL | Location" | ||
| } | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Updated
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…iple baseline files
|
🤔It seems that we need to separately make |
|
|
||
| interface URL { | ||
| constructor signatureIndex=0 { | ||
| param url overrideType="string | URL | Location" |
There was a problem hiding this comment.
Why not additionalTypes? 🤔
There was a problem hiding this comment.
Because location is not supported in web worker, i don't know how to handle web worker
There was a problem hiding this comment.
the exposure checker should autoremove them... but maybe we don't do that for additionalTypes? 🤔
…ethod parameters across multiple baseline files
|
It wasn't implemented, but I have added it Kagami Sascha Rosylight (@saschanaz) |
3 participants
closes #2536
Also, I couldn't figure out how to override fetch