Repository navigation
fix(sleep): schedule forwards --scope to the scheduled run - #413
Open
Aditya Nikam (adityaanikam) wants to merge 1 commit into
Open
Aditya Nikam (adityaanikam) wants to merge 1 commit into
Aditya Nikam (adityaanikam) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #405.
cmd_scheduleread--scopebut never passed it on, and_runner_cmdwrote--scope invokedinto every scheduled command. Soschedule --scope allinstalled a nightly job that harvested only the invoked project.schedule()now takes ascopeargument that defaults to"invoked", andcmd_schedulepassesargs.scopethrough._runner_cmdrefuses any value other thaninvokedorall. Callers that do not pass a scope, such as the openclaw plugin, get the same command as before.Two new tests in
tests/test_sleep_scheduler_safety.py: the command carries the requested scope (the default is unchanged), and an unknown scope is refused before anything is written to crontab. Both fail on main and pass here. The first only runs on POSIX, like the quoting test next to it, so I ran the file on Linux as well as Windows.