Skip to content

FIX fail closed on realtime audio swap errors - #2666

Merged
Roman Lutz (romanlutz) merged 1 commit into
microsoft:mainfrom
romanlutz:romanlutz-daily-audit-2026-09-14
Sep 15, 2026
Merged

Roman Lutz (romanlutz) merged 1 commit into
microsoft:mainfrom
romanlutz:romanlutz-daily-audit-2026-09-14

Conversation

@romanlutz

Copy link
Copy Markdown
Contributor

Why

When a realtime request converter inserts converted audio, failure to delete the original committed audio was logged and ignored. The session then requested a response with both raw and converted audio in context, silently defeating the converter.

This is a follow-up to #2463, which covers audio-source iterator failure earlier in the streaming lifecycle. It does not exercise the committed-audio replacement path.

What changed

  • Propagate raw-item deletion failures instead of continuing to response.create.
  • Preserve the successful-path ordering: insert converted audio, then delete raw audio.
  • Add regression coverage proving deletion failure prevents response creation, audio saving, and message persistence.

Validation

  • 33 focused realtime streaming-session tests passed.
  • 1,163 prompt-target tests passed, 30 skipped.
  • Ruff, formatting, changed-file typing, compilation, lock, and diff checks passed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 21bf73f6-4b26-4f5f-bb22-01fa72e49186
@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Sep 15, 2026
Merged via the queue into microsoft:main with commit 89799c4 Sep 15, 2026
49 checks passed
@romanlutz
Roman Lutz (romanlutz) deleted the romanlutz-daily-audit-2026-09-14 branch September 15, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants