Graph-IVF: add SPFresh-style LIRE maintenance - #1369
Draft
xwj-ox wants to merge 3 commits into
Draft
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
SPFresh: https://www.microsoft.com/en-us/research/publication/spfresh-incremental-in-place-update-for-billion-scale-vector-search/
What does this implement/fix? Briefly explain your changes.
This replaces Graph-IVF's independent split and dissolve maintenance with a synchronous, in-memory adaptation of SPFresh's LIRE protocol. It adds capacity-balanced binary splits, the two necessary-condition filters for possible NPA violations, deduplicated global routing of filtered candidates, post-retirement merge rerouting, and split/merge cascade convergence.
The merge planner first searches the existing mutable centroid Vamana graph, exactly reranks the bounded candidate set, and applies projected-capacity filtering. It progressively widens the candidate budget and uses a packed, one-pass exact fallback without restoring the previous all-centroid allocation and full sort. All victims in the same batch are excluded, and planned target capacity is reserved across the batch.
The change preserves final global NPA routing and overflow cascades. It does not implement SPFresh's asynchronous Local Rebuilder, version/replica GC, SSD Block Controller, or snapshot/WAL system layer.
Validation completed locally:
cargo test -p diskann-graphivf: 89 unit tests and 11 integration tests passed.cargo clippy -p diskann-graphivf --all-targets -- -D warningspassed.cargo fmt --all --checkandgit diff --checkpassed.Any other comments?
This is intentionally a draft. A fresh A1-B1-B2-A2 comparison against
u/adkrishnan/graph-ivfis running with the original 1,280-stage MSTuring30M runbook, all 640 search checkpoints, 1,000 queries per checkpoint, per-run corpus warmup, isolated indexes, and interleaved final disk sweeps. The PR should remain draft until the ABBA variance analysis is complete and theclusters_updatedinstrumentation from90cb5cafis reconciled across both arms. Local experiment logs and HTML reports are intentionally excluded from this PR.