Repository navigation
Reduce 32-bit zstdmt maximum job size to 256 MB - #4946
Open
kevinjzhang wants to merge 1 commit into
Open
kevinjzhang wants to merge 1 commit into
kevinjzhang wants to merge 1 commit into
Conversation
On 32-bit builds, a level 22 stream with nbWorkers=1 needs a 2 GiB round buffer (4 x 512 MB), which malloc cannot provide in a 32-bit address space, so compression fails with memory_allocation. Lower ZSTDMT_JOBLOG_MAX from 29 to 28 and ZSTDMT_JOBSIZE_MAX from 512 MB to 256 MB on 32-bit builds, so the same case needs 1 GiB. 64-bit builds are unchanged. Addresses meta#4628.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 32-bit builds, a level 22 stream with
nbWorkers=1needs a 2 GiB round buffer (4 x 512 MB), whichmalloccannot provide in a 32-bit address space, so compression fails withmemory_allocation(#4628).Lower
ZSTDMT_JOBLOG_MAXfrom 29 to 28 andZSTDMT_JOBSIZE_MAXfrom 512 MB to 256 MB on 32-bit builds, as such systems should not be using such resource intensive jobs anyway.Notes: