Repository navigation
Conversation
terrelln
force-pushed
the
2026-11-12-seekable-failed-seek-retry
branch
from
November 12, 2026 18:41
bed67e6 to
f98e66f
Compare
Invalidate the cached frame before seeking, and record the new frame only after its input and decoder state are initialized. Otherwise a failed seek can leave a new object with a NULL input pointer, and retrying within the same frame bypasses initialization. Add a malformed 65-byte archive regression covering in-memory and custom sources, repeated failed reads, and recovery to a valid frame.
terrelln
force-pushed
the
2026-11-12-seekable-failed-seek-retry
branch
from
November 12, 2026 20:40
f98e66f to
d555811
Compare
Cyan4973
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalidate the cached frame before seeking, and record the new frame only after its input and decoder state are initialized. Otherwise a failed seek can leave a new object with a NULL input pointer, and retrying within the same frame bypasses initialization.
Add a malformed 65-byte archive regression covering in-memory and custom sources, repeated failed reads, and recovery to a valid frame.