Repository navigation
Conversation
terrelln
force-pushed
the
2026-11-11-ddict-hash-fixes
branch
from
November 11, 2026 19:47
ee6abec to
b2560a0
Compare
Terminate multi-DDict lookup at NULL entries, not dictionary ID zero. Cover missing and registered IDs that collide with a raw-content dictionary, using distinct dictionary contents.
Compare scaled occupancy directly so the table grows at 75% instead of 25%. Count allocations and verify buffered-streaming lookup after rehashing, independently of the one-shot decoder changes.
terrelln
force-pushed
the
2026-11-11-ddict-hash-fixes
branch
from
November 12, 2026 20:38
b2560a0 to
eac75fd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in the experimental, opt-in
ZSTD_d_refMultipleDDictsmode:Additionally, one temporary fix so that dictionaries are only selected for a valid zstd frame header, so that the added regression tests pass. A more comprehensive fix will be stacked on these changes.
Adds regression tests in tests/fuzzer.c using dictionaries with distinct contents and checking decoded bytes. The tests cover missing and registered IDs that collide with ID 0, successful raw-dictionary lookup, the allocation threshold, and lookup after rehashing.
The test case infrastructure will be reused for a stacked PR that changes multi-DDict behavior more.