Repository navigation
Conversation
With useRealPaths set, getPathSafe and the allowlist overload of getPath check realpath(filePath) but returned the lexically normalized path. The two differ when a symlink inside the base directory is followed by "..", so the caller could open a file outside the base. Return the path that was checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
useRealPathsset,SafePath::getPathSafeand the allowlist overload ofSafePath::getPathcheckrealpath(filePath)against the base directory or allowlist, but return the lexicalcleanPathresult. The two disagree when a symlink inside the base is followed by..: with base/srv/wwwand/srv/www/assets -> /srv/www/static/v2/assets, the input/srv/www/assets/../../secret.txtresolves to/srv/www/static/secret.txtand passes the check, while the returned path is/srv/secret.txt. A file outside the base can be reached this way whenever a file exists at the mirrored path inside it (for example one a client uploaded).Return the path that was actually validated: the real path when
useRealPathsis set, the normalized path otherwise (unchanged). Keeping this insideSafePathmeans the checked path and the opened path are the same string, so callers don't have to re-validate.Verified by building the unmodified
SafePathUtils.cppwith g++ against small folly/fmt shims and a directory link: before the change both overloads return and open the out-of-base file, after it they return the in-base file, and ordinary lookups are unaffected. I could not run the full getdeps build on this machine.