You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(content-plugins): reproduce the loading of non-Markdown files of a folder named like a Markdown file - #13037
Since we switched to tinyglobby (#11042), the docs, blog and pages plugins load every file of a folder whose name matches their include patterns. Tinyglobby appends /** to every pattern by default (expandDirectories: true), unlike globby: **/*.{md,mdx} matches folder.md/notes.txt.
The site build then fails, because the .txt file goes through the JS loader:
× Module parse failed:
╰─▶ × JavaScript parse error: Expected a semicolon or an implicit semicolon after a statement, but found 'notes'
This PR adds tests capturing the current behavior: a folder.md/ fixture folder containing a Markdown file and a notes.txt file, for each of the 3 plugins.
Test Plan
Unit tests. A dogfood repro would break the website build.
Blog posts, documentation, and pages are now correctly discovered when stored in folders whose names end in .md, including when those folders contain non-Markdown files.
… a folder named like a Markdown file
The docs, blog and pages plugins load every file of a `folder.md/`
directory, like `folder.md/notes.txt`, as content.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No actionable comments were generated in the recent review.
Walkthrough
The blog, docs, and pages plugin tests add fixtures and assertions for content files located inside a directory named folder.md.
Changes: Markdown-Named Content Folders
Layer / File(s)
Summary
Blog folder loading packages/docusaurus-plugin-content-blog/src/__tests__/__fixtures__/website-with-folder-named-like-post/blog/folder.md/*, packages/docusaurus-plugin-content-blog/src/__tests__/index.test.ts
The fixture contains a post and a text file inside folder.md. The test checks that both source paths are loaded.
This change only adds tests and fixtures that document a known bug before a stacked fix. It does not alter runtime behavior, so merge risk is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the change accurately: it adds tests that reproduce a bug where non-Markdown files inside a directory named like a Markdown file (folder.md/notes.txt) get loaded as content by the docs…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the change accurately: it adds tests that reproduce a bug where non-Markdown files inside a directory named like a Markdown file (folder.md/notes.txt) get loaded as content by the docs, blog, and pages plugins. The raw summary and objectives confirm that the changeset adds fixtures and tests for exactly this scenario across the three plugins. The title is specific, concise, and follows the conventional-commit style. It does not describe the fix, which is in a stacked PR, but the objectives say this PR is a reproduction only, so the title matches the main change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedSigned Facebook CLApr: maintenanceThis PR does not produce any behavior differences to end users when upgrading.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reproduce a bug before fixing it in a stacked PR.
Since we switched to tinyglobby (#11042), the docs, blog and pages plugins load every file of a folder whose name matches their
includepatterns. Tinyglobby appends/**to every pattern by default (expandDirectories: true), unlike globby:**/*.{md,mdx}matchesfolder.md/notes.txt.The site build then fails, because the
.txtfile goes through the JS loader:This PR adds tests capturing the current behavior: a
folder.md/fixture folder containing a Markdown file and anotes.txtfile, for each of the 3 plugins.Test Plan
Unit tests. A dogfood repro would break the website build.
Test links
Deploy preview: https://deploy-preview-13037--docusaurus-2.netlify.app/
Related issues/PRs
🤖 Generated with Claude Code
Summary by CodeRabbit
.md, including when those folders contain non-Markdown files.