You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci: build the PWA plugin in FIPS mode, to reproduce its empty precache - #13020
Reproduces a bug of @docusaurus/plugin-pwa in FIPS mode (#10963), fixed by #13012 stacked on top. The Build FIPS check of this PR is expected to fail.
In FIPS mode, Node.js rejects MD5. The PWA plugin calls Workbox to list the files that the service worker precaches for offline mode, and Workbox hashes each file with MD5 (hardcoded, no option to change it: GoogleChrome/workbox#3366).
Workbox doesn't fail: it catches the error, returns it as a warning that the plugin ignores, and writes an empty list. The site builds successfully, but offline mode silently precaches nothing.
This PR adds the PWA plugin to the Build FIPS test site, and a step checking that the built sw.js precaches files. A successful build isn't enough to catch this bug.
Test Plan
The new Check the PWA precache manifest step of the Build FIPS workflow should fail with The service worker precaches no file.
The FIPS build now checks that the generated service worker contains 64-character hexadecimal revision identifiers and fails if none are found, making missing revision data visible in the build result.
The generated test site now includes progressive web app support, using a plugin version that matches the site’s Docusaurus core version. This ensures the test site’s build configuration includes the PWA plugin.
No actionable comments were generated in the recent review.
Walkthrough
The FIPS build workflow adds the PWA plugin to its generated test site. After the build, it counts 64-character hexadecimal revision values in the generated service worker and fails if none are found.
Changes: FIPS PWA precache verification
Layer / File(s)
Summary
Configure and verify PWA build .github/workflows/build-fips.yml
The workflow installs @docusaurus/plugin-pwa at the generated project's @docusaurus/core version and configures the site to load the plugin. After the build, it counts matching revision values in build/sw.js and fails if the count is zero.
meta/docusaurus#13007: This PR introduces the FIPS workflow that this change extends.
Merge Risk: Minimal · up to 72fdb
This PR only changes a CI workflow to reproduce a known FIPS-mode problem in the PWA plugin. It does not affect shipped behavior. The Build FIPS check is expected to fail until the stacked fix lands.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: building the PWA plugin in FIPS mode to reproduce the empty precache. The raw summary confirms the workflow adds @docusaurus/plugin-pwa to the FIPS test site and check…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: building the PWA plugin in FIPS mode to reproduce the empty precache. The raw summary confirms the workflow adds @docusaurus/plugin-pwa to the FIPS test site and checks sw.js for 64-character hex revisions. The objectives say the PR reproduces the MD5/FIPS precache issue (#10963), which the title matches. The title is specific and uses the conventional 'ci:' prefix, so it passes.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 18051695-4013-4903-af84-3aa16f1f1401
Commits
Reviewing files that changed from the base of the PR and between d20956b and 72fdbb3.
Files selected for processing: 1
.github/workflows/build-fips.yml
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.
Workbox hashes the precached files with MD5. In FIPS mode, it doesn't
fail the build: it only warns, and the service worker precaches nothing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedSigned Facebook CLApr: maintenanceThis PR does not produce any behavior differences to end users when upgrading.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Reproduces a bug of
@docusaurus/plugin-pwain FIPS mode (#10963), fixed by #13012 stacked on top. TheBuild FIPScheck of this PR is expected to fail.In FIPS mode, Node.js rejects MD5. The PWA plugin calls Workbox to list the files that the service worker precaches for offline mode, and Workbox hashes each file with MD5 (hardcoded, no option to change it: GoogleChrome/workbox#3366).
Workbox doesn't fail: it catches the error, returns it as a warning that the plugin ignores, and writes an empty list. The site builds successfully, but offline mode silently precaches nothing.
This PR adds the PWA plugin to the
Build FIPStest site, and a step checking that the builtsw.jsprecaches files. A successful build isn't enough to catch this bug.Test Plan
The new
Check the PWA precache manifeststep of theBuild FIPSworkflow should fail withThe service worker precaches no file.Test links
Deploy preview: https://deploy-preview-13020--docusaurus-2.netlify.app/
Related issues/PRs
🤖 Generated with Claude Code
Summary by CodeRabbit