Next hop reliability - #3359
Draft
OverkillFPV wants to merge 2 commits into
Draft
Conversation
When a repeater forwards a direct (path-routed) packet and there is a further hop in its remaining path, it now tracks the packet's hash and waits to overhear the next hop repeating it as implicit confirmation of receipt. If no repeat is heard within a timeout, the packet is resent, up to 3 retries, before being dropped. - Mesh.h: add PendingNextHopConfirm table + getNextHopReliabilityEnabled(), getNextHopMaxRetries(), getNextHopConfirmTimeout() virtual hooks for tuning. - Mesh.cpp: register a pending confirm after forwarding a direct packet with a remaining path, check overheard direct packets against the pending table, and process retries/timeouts each loop().
Companions, repeaters, and room servers that originate a direct packet (via Mesh::sendDirect()) now also register it for next-hop reliability tracking when there's at least one hop in the path, so the sender itself listens for the first hop to repeat it and retries just like an in-transit repeater would.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at direct path reliability using retries if a repeat is not heard, I reckon the extra airtime implication of retries either for failed packets, or not heard repeats that were actually repeated is overall not as big of an impact of a complete resend. only a draft as i am testing the first revision of it.