Raise the CMake floor from 3.17 to 3.19 - #2668
Merged
Merged
Conversation
Machinery to add *.ext manifests which contain JSON to be parsed by CMAKE with `string( JSON )` requires a minimum CMake version 3.19. The cmake_policy( VERSION 3.17.0 ) pins under tools/ are deliberately left alone: raising the floor should not quietly change policy behaviour in the directories that explicitly fixed it. Bumping those is a separate decision.
Contributor
|
As such not much of a formal review needed. - Will let the tests run through and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machinery to add *.ext manifests which contain JSON to be parsed by CMAKE with
string( JSON )requires a minimum CMake version 3.19.The cmake_policy( VERSION 3.17.0 ) pins under tools/ are deliberately left alone: raising the floor should not quietly change policy behaviour in the directories that explicitly fixed it. Bumping those is a separate decision.
If this PR is accepted, the second commit of #2666, 1603570, can be dropped (though it should be harmless to keep it in place).
Declaration of use of AI-tools
Opus 5 identified all instances of
CMakeLists.txtwhich needed a higher minimumCMakeversion.My contribution contains something else