fix: keep inline code as a code element in Typst output - #65
Merged
Merged
Conversation
A Typst document with inline code and no code block failed to compile, because Pandoc had nothing left to highlight and wrote no token definitions for the tokens the inline pass had already written. The filter now builds the definitions from the document's own highlight method and writes them once.
The inline pass rendered each Code element to Typst itself and put the result in a raw inline. Pandoc then had nothing to highlight, so it wrote no token definitions. The pass now wraps the element in place. Pandoc highlights it, writes the definitions, and the inline output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Typst document with inline backtick code and no code block failed to compile, with
error: unknown variable: NormalTok.The inline pass rendered each
Codeelement to Typst itself and put the result in a raw inline. Pandoc was then left with nothing to highlight, so it wrote no#let NormalTok(s) = ...definitions, and the token calls in the body had nothing to resolve against. A code block in the same document hid the problem, because the block made Pandoc write the definitions.The pass now wraps the element in place, between the raw inline that opens the box and the one that closes it. Pandoc highlights the element, writes the definitions and escapes the text itself.
pandoc.writeonce per inline code span no longer.tests/fixtures/inline-code-only.qmdcovers the document that failed, andtests/fixtures/inline-code-no-theme.qmdcovers the box used when the theme gives no background colour.