Repository navigation
Show why an OAuth consent request was rejected - #7
Merged
Merged
Conversation
The consent page replaced every AuthorizationError with a generic 'could not be verified', hiding the library's specific, non-sensitive reason (e.g. authorization not started in this browser, expired or already used, unknown client, redirect mismatch) and logging nothing, so real-world failures could not be diagnosed. Show the reason to the signed-in admin and log it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consent page turned every
AuthorizationErrorinto the generic Connection request could not be verified, hiding the library's own reason and logging nothing. That made a real-world failure impossible to diagnose.Now the page shows the library's fixed, non-sensitive description (escaped; only a signed-in admin sees this page) and logs the code + description. The OAuth smoke test asserts the reason is shown for a consent without the browser-binding cookie.
Tested: full production-worker smoke suite incl. OAuth.
🤖 Generated with Claude Code