Repository navigation
Conversation
Contributor
Author
|
@XuPeng-SH could you please review this PR? It adds a default-off SIMD coverage mode so the shared UT coverage producer can run the SIMD implementations and tests used by MatrixOne production builds. Existing callers retain their mode, and coverage thresholds/exclusions stay unchanged. The workflow validator has passed. This is the shared-CI prerequisite for matrixorigin/matrixone#32325 and matrixorigin/matrixone#32237. |
15 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Part of matrixorigin/matrixone#32325. The issue remains open until the MO caller is enabled and the required merged coverage gate is verified.
What this PR does / why we need it:
Add a default-off
simd_coverageinput to the UT coverage workflow. Enabling it selectsGOEXPERIMENT=simdandGOAMD64=v3before package discovery, instrumentation, native preparation and test execution, and logs compiler/platform/build-mode identity. Omitted or false preserves the existing environment.Coverage currently invokes Go directly and can exclude SIMD-tagged tests even when the production binary includes their implementation. Keep the existing runner, package scope, assertions, thresholds, exclusions, permissions and artifact protocol. Add fast environment/failure contract tests, including propagation through the actual runner, and enforce them in the workflow validator without requiring SIMD hardware or a new Go SDK there.
Design and validation
python3 scripts/test_coverage_build_mode.py -v: 6 tests pass (1.406s), covering omitted/false/true, preservation of ambient values, ordering, actual-runner inheritance and rejection before discovery.Delivery
Merge this prerequisite first. The separate MO caller PR is prepared locally and will be published only after this workflow ref accepts the new input. The ordinary MO UT lane remains scalar. Because MO uses
pull_request_target, verify actual opt-in execution in a fresh decimal PR CI generation after the caller merges; local unit coverage is not the final merged coverage verdict.