Repository navigation
Conversation
Contributor
Author
|
Closing this candidate: the global resource limits increased ARM SCA time substantially without demonstrating sufficient cgroup headroom, and enabling incremental license checks for the current configuration can miss files from changes that bypass SCA. The remaining dependency-only optimization saves approximately two seconds and does not justify its complexity. MatrixOne issue #31428 remains open for further investigation; this PR does not establish the original OOM root cause or fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge: the ARM candidate failed the resource and latency acceptance criteria below. The resource limits are being reconsidered.
Problem
Related to matrixorigin/matrixone#31428. An ARM64 SCA runner with an 8 GiB cgroup limit was OOM-killed on PR #31420. Its original logs did not establish which process or phase caused the incident. The same source on the same runner class later completed a full scan with its cgroup peak at 8 GiB and 13 memory.max events; this peak includes reclaimable file cache and is not process RSS.
Change
GOFLAGS=-p=1and a defaultGOMEMLIMIT=5GiBto the existing SCA make invocation, including its legacy fallback. Preserve pre-existing GOFLAGS and an explicit GOMEMLIMIT. The memory target is soft and per Go process; it is not a container-wide cap.matrixorigin/matrixonemain. Unknown base, config, recipe, or missing path information retains full checks.No analyzer or test selection is removed. Serial package actions may increase analysis elapsed time; the incident's exact original allocation cause remains unverified.
Validation
node --test actions/resolve-sca-license-scope/scope.test.js: 22 passed.actionlintv1.7.12 andgit diff --checkpassed. Go source is unchanged; Go UT race is not applicable to this CI-only delta.makeelapsed 2253.765s; tuned 3270.633s (+1016.868s, about 17 min). The 8 GiB cgroup lifetime peaks were 8589934592 and 8589930496 bytes;memory.events maxwere 13 and 1, with no OOM kill in either run. This does not demonstrate useful cgroup headroom. golangci Go runtime memory max fell from 7856.7 MB to 5749.4 MB, but that is neither process RSS nor total container memory.The separately discovered molint diagnostic-protocol defect is tracked in matrixorigin/matrixone#31455; a successful run with the old tool is not proof that molint had no findings.