Repository navigation
Conversation
…c-cts-param-runtime.test.ts
vishwach
marked this pull request as ready for review
November 20, 2026 04:35
vishwach
requested review from
NiteshMehta,
adganta,
ashokrprogress,
hmadala001,
prgs-rsingh and
rjrudin
as code owners
November 20, 2026 04:35
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the cts.param smoke-test improvements.
No open issues 🎉
What changed in this PR
This PR strengthens the cts.param Optic smoke tests by checking that a serialized parameter node exists before accessing its properties.
Changes:
- Replaces
anyin the lookup helper withunknownand a record type guard, simplifying nested traversal. - Centralizes node validation in
requireCtsParamusing Node’s strict assertions. - Adds helper tests for missing and nested nodes and updates serialization assertions.
| File | Description |
|---|---|
test-typescript/optic-cts-param-runtime.test.ts |
Adds typed node lookup, shared existence validation, and regression coverage for lookup behavior. |
Review effort: Balanced
NiteshMehta
approved these changes
Nov 20, 2026
adganta
approved these changes
Nov 20, 2026
hmadala001
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
should.exist(paramNode)assertions with explicit null checks throwing descriptive Errors inoptic-cts-param-runtime.test.ts.paramNode.nsandparamNode.fn, satisfying Polaris CFG data-flow analysis and narrowing TypeScript types.Verification
Verified and it passed locally:
npx mocha test-typescript/optic-cts-param-runtime.test.js