Skip to content

MLE-33567: Park tests blocked on MarkLogic server bugs - #1988

Merged
vishwach merged 1 commit into
developfrom
MLE-33567
Nov 17, 2026
Merged

vishwach merged 1 commit into
developfrom
MLE-33567

Conversation

@vishwach

@vishwach vishwach commented Nov 5, 2026 •

Copy link
Copy Markdown

For RowBatcherTest.noRowsReturned: Running an Optic query used to return zero rows previously which crashed MarkLogic Server due to an unhandled exception in SPARQL/inference query preparation (Fix as part of this : MLE-24579). Verified that the crash is resolved in MarkLogic 12 with no server restarts or side effects. Removed @disabled and added @ExtendWith(RequiresML12.class) so the test executes on ML 12+ while safely skipping on older server matrices to prevent CI instability.

For ReadJsonAsBinaryTest (MLE-27191) and RowManagerTest(MLW-214) the fix is not in place yet, thus added a detailed comment and left as-is.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 06:19
@vishwach
vishwach marked this pull request as draft November 5, 2026 06:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The re-enabled test previously restarted MarkLogic, and only version 12 validation is documented, so MLE-24579 fix coverage or a version guard must be confirmed for older supported servers.

No open issues 🎉

What changed in this PR

Updates server-bug tracking in the core Java client tests and restores zero-row query coverage following the reported MarkLogic 12 fix.

Changes:

  • Re-enables RowBatcherTest.noRowsReturned by removing its @Disabled annotation.
  • Clarifies the server bugs blocking two other tests without changing their disabled status.
File Description
marklogic-client-api/​src/​test/​java/​com/​marklogic/​client/​test/​rows/​RowManagerTest.java Clarifies the Optic facet-by bug in the disabled-test reason.
marklogic-client-api/​src/​test/​java/​com/​marklogic/​client/​test/​document/​ReadJsonAsBinaryTest.java Clarifies the incorrect document-format response in the disabled-test reason.
marklogic-client-api/​src/​test/​java/​com/​marklogic/​client/​test/​datamovement/​RowBatcherTest.java Re-enables the zero-row query regression test.

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are blocking the regression-test updates.

No open issues 🎉

Review effort: Balanced

@prgs-rsingh

Copy link
Copy Markdown

verified all 3 test updates in this PR:

RowBatcherTest.noRowsReturned: Good use of @ExtendWith(RequiresML12.class) so we regain test coverage for empty-result RowBatcher jobs on MarkLogic 12+ while avoiding the MLE-24579 server crash on ML 11 and older.
ReadJsonAsBinaryTest & RowManagerTest.testBug58233: Clear, self-contained @disabled("Blocked by server bug ...") descriptions make the root cause immediately obvious without having to look up the Jira tickets.
Functional Coverage Check
Net gain on ML 12+: RowBatcherTest.noRowsReturned is now active on MarkLogic 12+.
No coverage lost: ReadJsonAsBinaryTest (MLE-27191) and RowManagerTest.testBug58233 (MLE-241) were already @disabled, and standard binary read/write (BinaryDocumentTest) as well as op.bucketGroup / op.facetBy with namedGroupSeq (RowManagerTest.testBucketGroup, RowManagerTest.testFacetBy) remain covered.
Minor Nits
Unused import in RowBatcherTest.java (line 28): import org.junit.jupiter.api.Disabled; is now unused since noRowsReturned() was the only @disabled test in RowBatcherTest and can be removed.
PR Description typo: The PR description mentions MLW-214 for RowManagerTest, whereas the code (correctly) references MLE-241.

@vishwach
vishwach marked this pull request as ready for review November 17, 2026 08:05
@vishwach
vishwach merged commit 44b4dd3 into develop Nov 17, 2026
5 checks passed
@vishwach
vishwach deleted the MLE-33567 branch November 17, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants