Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The re-enabled test previously restarted MarkLogic, and only version 12 validation is documented, so MLE-24579 fix coverage or a version guard must be confirmed for older supported servers.
No open issues 🎉
What changed in this PR
Updates server-bug tracking in the core Java client tests and restores zero-row query coverage following the reported MarkLogic 12 fix.
Changes:
- Re-enables
RowBatcherTest.noRowsReturnedby removing its@Disabledannotation. - Clarifies the server bugs blocking two other tests without changing their disabled status.
| File | Description |
|---|---|
marklogic-client-api/src/test/java/com/marklogic/client/test/rows/RowManagerTest.java |
Clarifies the Optic facet-by bug in the disabled-test reason. |
marklogic-client-api/src/test/java/com/marklogic/client/test/document/ReadJsonAsBinaryTest.java |
Clarifies the incorrect document-format response in the disabled-test reason. |
marklogic-client-api/src/test/java/com/marklogic/client/test/datamovement/RowBatcherTest.java |
Re-enables the zero-row query regression test. |
Review effort: Balanced
|
verified all 3 test updates in this PR: RowBatcherTest.noRowsReturned: Good use of @ExtendWith(RequiresML12.class) so we regain test coverage for empty-result RowBatcher jobs on MarkLogic 12+ while avoiding the MLE-24579 server crash on ML 11 and older. |
For RowBatcherTest.noRowsReturned: Running an Optic query used to return zero rows previously which crashed MarkLogic Server due to an unhandled exception in SPARQL/inference query preparation (Fix as part of this : MLE-24579). Verified that the crash is resolved in MarkLogic 12 with no server restarts or side effects. Removed @disabled and added @ExtendWith(RequiresML12.class) so the test executes on ML 12+ while safely skipping on older server matrices to prevent CI instability.
For ReadJsonAsBinaryTest (MLE-27191) and RowManagerTest(MLW-214) the fix is not in place yet, thus added a detailed comment and left as-is.