Repository navigation
perf: speed up version metadata reads - #668
Merged
Merged
Conversation
get-version-metadata reads Info.plist out of the remote IPA through httpRangeReaderAt. archive/zip parses the central directory through a 4 KiB bufio.Reader, and each ReadAt was a separate range request. Those requests go through the Store "transfer" client, which opens the emulator for every request, so an IPA with many files cost hundreds of emulator round trips: 298 requests and ~71s (55s CPU) for one Chrome version. On a miss, httpRangeReaderAt now fetches at least 1 MiB starting at the requested offset and serves later reads from that window. Reads that cross EOF are still clamped, and only the end of the IPA is downloaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #663.
Add 1 MiB read-ahead caching for remote IPA reads so
get-version-metadataavoids repeated small range requests and Store emulator executions while parsing ZIP central directories.Preserve usable data from interrupted read-ahead responses, validate
Content-Rangebefore caching, and add regression coverage for cache boundaries, backward reads, EOF, and concurrent access.