ci: declare accepted secrets on dependabot rebase workflow - #102
Closed
nickolas-dimitrakas wants to merge 1 commit into
Closed
nickolas-dimitrakas wants to merge 1 commit into
nickolas-dimitrakas wants to merge 1 commit into
Conversation
Declares the specific secrets this reusable workflow needs under on.workflow_call.secrets, so callers can pass them explicitly instead of using secrets: inherit. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 811e5da. Bugbot is set up for automated code reviews on this repo. Configure here. |
1 task
nickolas-dimitrakas
added a commit
to mParticle/mparticle-android-sdk
that referenced
this pull request
Sep 17, 2026
* ci: scope dependabot rebase workflow secrets Replaces secrets: inherit with an explicit mapping of only the secrets the rebase workflow actually uses, so the release signing and publish credentials this repo carries are no longer part of what gets passed along. Depends on mParticle/mparticle-workflows#102 declaring these secrets as accepted workflow_call inputs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * docs: link CHANGELOG entry to PR #818 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * ci: remove unused dependabot rebase workflow This workflow only ever ran against the stale development branch (AGENTS.md already flags that branch as unused) and forwarded this repo's full release secret set to an external reusable workflow to do it. Nothing depends on it, so remove it instead of narrowing what it forwards. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * revert: drop manual CHANGELOG entry CHANGELOG entries are generated automatically; don't hand-add them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Signed-off-by: Nickolas Dimitrakas <nickolas.dimitrakas@rokt.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Closing — the only caller of this workflow (mparticle-android-sdk's dependabot-rebase-branch.yml) is being removed instead of updated to use explicit secrets, so this change is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
secrets: inheritto run it, since it doesn't declare which secrets it accepts.What Has Changed
MP_SEMANTIC_RELEASE_BOT,GPG_PRIVATE_KEY, andGPG_PASSPHRASEunderon.workflow_call.secrets, matching what the job already references. This lets callers pass only those specific secrets explicitly instead of inheriting their whole secret set.Checklist
secrets: inherit).🤖 Generated with Claude Code