Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
✅ Deterministic PR hygiene checks passed. |
Draft
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Translated Messages requests could forward Anthropic's optional hosted Advisor while token ceilings were configured, although the main model's terminal usage does not independently account for that secondary work.
Addresses the Daybreak finding.
Verification
Linux, Bun 1.4.4; injected synthetic transports and the production ledger.
A one-token identity ceiling reproduced HTTP 429 before dispatch in four direct hosted-Advisor OAuth cases in the preceding implementation: both Anthropic instances, with account pooling on and off. The revised cases return HTTP 200 with one main-model send and withhold the optional Advisor. Combo controls retained HTTP 200. The tested no-Advisor Messages/Responses paths already returned HTTP 200; preservation controls keep their existing observe-only mode and identity-ledger behavior.
claude-translated-advisor-tool.test.tsThe final synthetic-credential spelling adjustment was checked with the affected API-key control again: 1 passed / 7 assertions. Typecheck covered 2,536 files with no errors; structure, privacy and staged whitespace checks passed.
The Combo regression also verifies a single pool-only Q reservation, no abandonment/rebooking, four actual sends, bounded reservation amounts and correct final pool settlement with no added identity debt. The prepared-route authority fixture and real upstream-socket-reset test preserve their original authorization and failure-accounting assertions.
Local testing is focused because the broad local suite includes provider/network paths beyond these synthetic fixtures. The four spend-anchor WS cases are excluded after the same local fixture timeout reproduced on the unchanged base; hosted CI remains the broader gate. The reset case uses an isolated preload that refuses non-loopback fetches. No live-provider or billing test is claimed.
The existing SSE mask timing-test correction remains in this branch: it measures excerpt masking separately while retaining complete rewrite/redaction assertions. Production masking is unchanged.
Independent source review covered the final runtime changes, credential boundaries, accounting scopes and regressions. Maintainer security approval and native-platform acceptance remain separate.
Hosted CI
Latest-head hosted CI is running for
644a7d821329cdde3f8d53fab19a9b194f48bb42; earlier-head results are not reported as validation of this commit.Checklist
The security checkbox records implementation review; explicit maintainer security review remains required before merge.