Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
UI screenshot waived by a maintainer comment. Hygiene✅ Deterministic PR hygiene checks passed. |
|
No GUI changes: only the target-switch test harness is changed, with no rendered component or production UI change. Verified the single-file diff at 87a04ca. Apply the repository-supported OWNER screenshot false-positive override; no CI requirement is waived. Upstream review is lidge-jun#8592. This is the isolated repair for the account-pool target-switch timing failure in #817. |
|
No description provided. |
The layout-commit wait still could not prove the new target's passive-effect read had started: the hook kicks it from a passive effect plus a queued microtask, so a trailing zero-delay timer could observe only two reads on a loaded runner (the still-open review finding). Wait until the fixture's own in-flight state is painted instead: refreshing turns true only after the read's fetch was issued and React committed the new counter, so the timer becomes a yield between observations rather than an effect-ordering assumption. Releasing the old read stays in the layout phase, preserving the regression window. Verified: bun test tests/codex-account-pool-target-switch.test.tsx -> 13 pass / 0 fail / 86 assertions (4 runs); bun run build (tsc -b + vite + vite classic) passed; git diff --check passed. Baseline and change both emit the same flaky not-wrapped-in-act noise, so none is introduced.
Summary
The account-pool target-switch regression test could assert before the new target's passive-effect read started. Wait for the layout commit and then the expected in-flight state, instead of assuming a zero-delay timer means the passive effect and its queued microtask have completed.
The old response is still released in the layout phase, preserving the regression window. Only the test helper changes; production code and existing assertions are unchanged.
Verification
Current head:
92bff195de8bf433f7ba0e0482c5dc9061d6cb1c.git diff --check: passed.Checklist