Repository navigation
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
df5363d to
7ecbd88
Compare
Restore resource cleanup and pending catalog retries while keeping account patrol disabled. Decide conservative replay from the latest plan/daily quota rejection, removing the stale quotaRejected reference. Report invalid worker setting keys and cover offline maintenance/cancellation behavior.
Preserve current main APIs and resource lifecycle while retaining the conservative profile. Resolve the runtime imports and removed idle-applet cleanup, and verify explicit login, blocked imports, bounded quota fallback, cleanup, and catalog retries. The v0.3.4 and v0.3.5 branch integrations produce the same complete tree.
Count only started generation attempts so preparing a copy on another account neither consumes the attempt budget nor triggers the replay policy before the first generation. Keep the last-error quota/authentication boundary for actual retries. Exercise the real retry loop and account pool with a narrow lease-acquisition boundary: one copy and generation on the alternate account, explicit failures, cancellation, and a one-account cooling result.
Current scope — 2026-11-17
This is the maintained conservative profile, now integrated with main
87284879a11bd1257641e8aae56a1e09b209ef1f.0629f2cf11313766d07dc3cd437dfe99626ecec3; source tree:78c2045cae428725a3e9d8f3a6417eb69d90bdb3.Complete transfer from #1
At transfer commit
82ceb6e6fa2a774bbe76c07e20100ba2df566e74, applying the same main integration, regression additions and required formatter to the retained #1 headdb088df35b7f29757bf7da4b98c533f87280d3d7with the same main produced the identical complete treecb63622196ade9b7c4ecffbe2b086301dd2a2773. The implementation, configuration, frontend and tests match across all 35 changed files relative to main (645 added / 15 removed lines). #1 is superseded by this PR; its branch and historical verification remain preserved.The three earlier single-account review suggestions belong to the earlier design and are superseded by the explicitly retained multi-account policy. The short-term 429 suggestion was reviewed separately: its stale-error concern is fixed, while broadening fallback beyond plan/daily quota is intentionally declined and covered by regression tests.
Building the conservative profile
The frontend and Go server use separate build switches. After the normal native-library setup, run both profile steps from the repository root:
The frontend step hides the profile's disabled import options; the Go tag enforces the corresponding server restrictions. For desktop builds, include
conservativealongside the platform's existing build tags and rebuild the frontend withVITE_CONSERVATIVE=1first. The ordinary CI/release build commands do not opt into this profile. The local conservative frontend verification reported here used that environment variable.Verification
0629f2c: all four jobs passed — frontend build, web typecheck/lint/format, Go unit tests, and minimum-version/Windows vet. Devin Review completed successfully; CodeRabbit skipped its automated review because this repository requires manual invocation.Linux, Go 1.27.3, the repository's pinned SpiderMonkey
v158.0.1-aistudio2api.2and libwebpv1.6.0-aistudio2api.1:go test -mod=readonly -p=2 -tags conservative ./internal/app ./internal/config -count=1: 11 top-level tests passed (44 pass entries including subtests).These checks use fixtures and mocks. No new installed-app, Windows, physical-device or live-provider verification is claimed.
Historical branch evidence
The original v0.3.5 description below is retained as earlier branch history. Its Windows/device results predate this main integration and do not validate the current head.
Summary
v0.3.5 기반 위에 conservative 빌드 프로필 두 커밋을 올린 사용자 검증 브랜치입니다.
7e9477ffeat: add conservative AI Studio web profile —-tags conservative빌드 시 자연스러운 웹 사용 패턴을 재현하는 프로필: Camoufox 백엔드 기본값, 계정당 동시성 1, first-event hedge/continuation rewrite/search-alias off, fill-first 라우팅, 관리자 인증 기본 활성, 클라이언트 귀속 문구 중립화.df5363dfix: allow conservative quota account fallback — 요금제·일일 한도 초과 시 같은 풀의 다음 계정으로 폴백. 일반적인 단기 429/Retry-After는 보수적 정책상 제외.Verified
-tags conservative) 성공, 바이너리 SHA256 고정 후 양 Windows 기기 배포state=RUNNING, Camoufox 워커 정상, 계정 풀(2계정) 인식POST /v1/chat/completionsmodel=gemini-4-argon →ARGON-OK응답(이 PC 25s 콜드 / Galaxybook 9s), OpenCodexArgon콤보 경유 시에도 정상Notes
WAA runtime occupied오류가 발생하므로 계정은 한 런타임 풀에만 둡니다.