[dv] Fix cosim parameter passing - #2501
Open
SamuelRiedel wants to merge 1 commit into
Open
SamuelRiedel wants to merge 1 commit into
SamuelRiedel wants to merge 1 commit into
Conversation
Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
gautschimi
reviewed
Sep 14, 2026
| `ifndef IBEX_CFG_BASE_ISA | ||
| `define IBEX_CFG_BASE_ISA ibex_pkg::BaseIsaRV32IorCHERIoT | ||
| `ifndef IBEX_CFG_BaseIsa | ||
| `define IBEX_CFG_BaseIsa ibex_pkg::BaseIsaRV32I |
Contributor
There was a problem hiding this comment.
is this changed to BaseIsaRV32I on purpose?
Contributor
Author
There was a problem hiding this comment.
Ah yes. It's a more sensible default IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cosim expects some parameters as defines which are provided by the ibex_configs file and python script. However, there was a mismatch in the exact spelling between https://github.com/lowRISC/ibex/blob/master/ibex_configs.yaml and the expected defines in the cosim tb. This aligns this.