Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
joe4dev
added
semver: patch
docs: skip
1 task
… Windows on system keyring Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The integration-test keyring helpers used the system keyring unless
LSTK_KEYRING=filewas set, whichmake test-integrationonly did on macOS. Running the logout tests locally (e.g.go test -run TestLogout) overwrote and then deleted the developer's reallstk loginkeychain entry.Solution
Default the suite to the file keyring and export
LSTK_KEYRING=fileso spawnedlstkprocesses agree.LSTK_TEST_SYSTEM_KEYRING=1opts back into the system keyring; the now-redundant macOS export inscripts/test-integration.shis removed so the opt-in also works viamake. Three Docker logout tests that runlstkwith an isolated HOME now seed the token into that HOME, since they only passed before because the keychain is global.CI: Linux and macOS already used the file keyring. Windows used Credential Manager and keeps doing so via
LSTK_TEST_SYSTEM_KEYRING=1.Docs
Test-harness only; nothing user-facing.
Review
Self-merge candidate: small, test-only change that removes a destructive local side effect.
🤖 Generated with Claude Code