Conversation
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 10:12
bc70c3a to
ba7d03d
Compare
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
2 times, most recently
from
September 22, 2026 10:39
75fb741 to
dd3f443
Compare
2 tasks
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 10:41
ba7d03d to
3170663
Compare
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
from
September 22, 2026 10:46
dd3f443 to
be579b7
Compare
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 10:47
3170663 to
476ffc4
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
from
September 22, 2026 12:56
be579b7 to
607b035
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
joe4dev
force-pushed
the
devx-1124-cask-install-steps
branch
from
September 22, 2026 12:57
476ffc4 to
7e5504e
Compare
joe4dev
force-pushed
the
devx-1124-guard-generated-homebrew-cask
branch
from
September 22, 2026 14:02
607b035 to
260bb75
Compare
Base automatically changed from
devx-1124-guard-generated-homebrew-cask
to
main
September 23, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Blocked by upstream — do not merge yet.
hooks.post.install_stepsexists in no released GoReleaser. It arrives in v2.19 through goreleaser/goreleaser#6873 (open, closes goreleaser/goreleaser#6870). Until then CI here fails twice over: the pin check rejects the released 2.18.2, andgoreleaser checkrejects the field itself:When v2.19 ships, re-running CI is enough — this PR already bumps
.tool-versionstogoreleaser 2.19.0.Motivation
#510 works around Homebrew's deprecated
postflightby writing the stanza throughcustom_block, at two costs:{{staged_path}}has to be escaped past GoReleaser's own template pass, and the stanza renders at the top of the cask, so every stanza after it tripsCask/StanzaOrder. #511 has to skip that cop to stay green.GoReleaser v2.19 adds the first-class option, which removes all three.
Solution
Replace
custom_blockwithhooks.post.install_steps, using GoReleaser's new.StagedPathfield in place of the escape. Behaviour is unchanged — the step still clears quarantine on the whole staged dir, as #477 made it.Also drops #511's
--except-cops=Cask/StanzaOrderand itsTODO(#512), and bumps the GoReleaser pin.Validation
Built GoReleaser from #6873 at its head (
38c7541) and ran it against this config:goreleaser checkpasses on the #6873 build, and fails on 2.18.2 with the error above.StagedPathrenders to Homebrew's{{staged_path}}token, and the generated stanza is byte-identical to the one Fix deprecated postflight stanza in the generated Homebrew cask #510 producesbrew stylereports no offences with no exception — against 9 on Fix deprecated postflight stanza in the generated Homebrew cask #510's outputCask::Artifact::PostflightStepswith no deprecation warningmake check-caskpasses, since it checks generated output rather than configThe install itself was verified on #510 for the identical stanza: quarantine cleared across all 43 staged files, and
lstk --versionruns.Stacking
Based on #511, so the diff reads as "replace the workaround". Retarget to
mainonce #511 merges.Docs
Nothing to document. No change to lstk's commands, flags, env vars or output, and no user-visible change to the cask's behaviour — this swaps the mechanism that generates an identical stanza.
Review
Human review advised: it touches the release pipeline, and merging it before v2.19 would break the release.
Todo
2.19.0is the version that actually ships #6873 before mergingTowards DEVX-1124
🤖 Generated with Claude Code