Repository navigation
Fix TypeError in /v1/completions when max_tokens is null - #3950
Open
davrens101 wants to merge 1 commit into
Open
davrens101 wants to merge 1 commit into
davrens101 wants to merge 1 commit into
Conversation
Signed-off-by: davrens101 <davis@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
CompletionRequest.max_tokensisOptional[int]and OpenAI allows"max_tokens": null. Increate_completion,check_lengthreturns an int for that case, but the following line compares it with the request value:so
/v1/completionswith"max_tokens": nullfails withTypeError: '<' not supported between instances of 'int' and 'NoneType'(HTTP 500) before anything is sent to a worker.The fix treats
Noneas "no limit requested", so the request is capped to the remaining context length (same as/v1/chat/completions, wheremax_tokens=Nonealready works).Before (mocked worker calls):
TypeError; the new unit test fails. After: test passes.Checks
format.shto lint the changes in this PR. (black --checkclean)AI-assistance disclosure: prepared with AI assistance; I reproduced the failure and reviewed the diff myself.