Conversation
Contributor
|
@Jipperism is attempting to deploy a commit to the Livepeer Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Jipperism
force-pushed
the
feat/722-Implement-Instrumentation-Plan
branch
6 times, most recently
from
September 19, 2026 01:47
51c5db2 to
b6b8be9
Compare
Adds custom events for the delegation funnel (nav click, page views, wallet connect, form start, transaction submit/confirm/fail) per the instrumentation plan in livepeer#722, so delegator UX changes can be measured against a baseline instead of guessed at. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Jipperism
force-pushed
the
feat/722-Implement-Instrumentation-Plan
branch
from
September 19, 2026 02:06
b6b8be9 to
cb374a4
Compare
Jipperism
marked this pull request as ready for review
September 19, 2026 02:10
Contributor
Author
|
@ECWireless ready for review |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
There are a couple of confirmed instrumentation correctness/data-quality gaps (notably route hydration causing double-fires and missing surface property on wallet_connected despite the PR description) that should be fixed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (4)
What changed in this PR
Adds Vercel Web Analytics to instrument the Explorer delegation funnel, including a typed analytics helper and event emission from key UI surfaces (nav, orchestrator pages, wallet connect, form start, and transaction lifecycle).
Changes:
- Added
@vercel/analyticswith<Analytics beforeSend={...} />and a newlib/analytics.tshelper to centralize event tracking/redaction. - Instrumented funnel events across Orchestrators pages, Account tabs, wallet connect, delegation form start, and transaction stages via
useHandleTransaction. - Extended transaction args to flag “Move Delegated Stake” (transfer-stake) so it maps to redelegation events.
| File | Description |
|---|---|
package.json |
Adds @vercel/analytics dependency. |
pnpm-lock.yaml |
Locks @vercel/analytics and related dependency updates. |
pages/_app.tsx |
Mounts Vercel <Analytics /> and applies URL redaction via beforeSend. |
lib/analytics.ts |
Introduces typed funnel event names, tracking helpers, URL redaction, and transaction→event mapping. |
layouts/main.tsx |
Instruments wallet connect and Orchestrators nav click (desktop + drawer item). |
pages/orchestrators.tsx |
Tracks Orchestrators index page view. |
pages/accounts/[account]/orchestrating.tsx |
Tracks orchestrator detail view once per account per session. |
pages/accounts/[account]/delegating.tsx |
Tracks “Delegating” tab view once for the connected user’s account. |
components/Drawer/index.tsx |
Wires drawer item onClick for nav click instrumentation. |
components/DelegatingWidget/index.tsx |
Tracks delegation form start on first clean→dirty transition per mount. |
components/DelegatingWidget/Delegate.tsx |
Passes isTransferStake into tx args for redelegation classification. |
hooks/useExplorerStore.tsx |
Adds isTransferStake?: boolean to transaction input data. |
hooks/useHandleTransaction.tsx |
Routes submitted/confirmed/failed stages into analytics transaction tracking. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+274
to
+285
| onConnect: ({ isReconnected }) => { | ||
| // Outside of migration and governance, connecting a wallet is taken as | ||
| // delegation intent. Reconnects restore a previous session, so they | ||
| // don't count. | ||
| const isNonDelegationPage = NON_DELEGATION_PATHS.some((path) => | ||
| asPath.startsWith(path) | ||
| ); | ||
| if (!isReconnected && !isNonDelegationPage) { | ||
| trackVercelAnalyticsEvent("wallet_connected"); | ||
| } | ||
| }, | ||
| }); |
Comment on lines
+28
to
+38
| const { query } = useRouter(); | ||
| const viewedAccount = String(query.account); | ||
|
|
||
| useEffect(() => { | ||
| if (!hadError) { | ||
| trackVercelAnalyticsEventOnce( | ||
| "orchestrator_detail_viewed", | ||
| viewedAccount | ||
| ); | ||
| } | ||
| }, [hadError, viewedAccount]); |
Comment on lines
+47
to
+49
| useEffect(() => { | ||
| trackVercelAnalyticsEvent("orchestrators_page_viewed"); | ||
| }, []); |
Comment on lines
+56
to
+63
| type TransactionEvents = Partial< | ||
| Record<TransactionStage, DelegationFunnelEvent> | ||
| >; | ||
|
|
||
| const REDELEGATION_EVENTS: TransactionEvents = { | ||
| submitted: "redelegation_started", | ||
| }; | ||
|
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #722
Summary
@vercel/analytics(<Analytics />in_app.tsx) and a typedtrackVercelAnalyticsEvent()helper inlib/analytics.ts. Event properties stay non-identifying: no addresses, ENS names, tx hashes or error text.surfaceproperty), delegation form start, delegation tx submitted/confirmed/failed, Delegating tab view, redelegation started, and unbonding started.useHandleTransaction. A "Move Delegated Stake"bondcounts asredelegation_startedonly, so it stays out of the delegation submitted → confirmed/failed conversion.delegation_form_startedfires once per widget mount, on the first clean → dirty transition.earn_entry_point_clickedanddelegation_review_opened, because the UI they depend on doesn't exist yet.Test plan
pnpm typecheck,pnpm lint,pnpm testpassredelegation_started) still need a check with a real wallet🤖 Generated with Claude Code