Skip to content

Update SIP 486 error test to expect new grpc code #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChelseaBradbury wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Update SIP 486 error test to expect new grpc code #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce3ca09
Fix sip 486 test to expect new grpc mapping
ChelseaBradbury Sep 3, 2026
54d1e3a
Update example sip error in readme
ChelseaBradbury Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ Failed API calls raise `LiveKit::ServerError`, which exposes the error `code`, m
begin
api.sip.create_sip_participant('trunk-id', '+15105550100', 'my-room', wait_until_answered: true)
rescue LiveKit::SipCallError => e
puts e # e.g. "SIP call failed: 486 Busy Here (resource_exhausted)"
puts e # e.g. "SIP call failed: 486 Busy Here (failed_precondition)"
puts e.sip_status_code # 486
rescue LiveKit::ServerError => e
puts e.code
Expand Down
2 changes: 1 addition & 1 deletion spec/api/livekit_api_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def sip_error(sip, wait: false)
it 'surfaces a busy signal as SipCallError' do
e = sip_error({ 'code' => 486, 'status' => 'Busy Here' })
expect(e).to be_a(LiveKit::ServerError)
expect(e.code).to eq('resource_exhausted')
expect(e.code).to eq('failed_precondition')
expect(e.sip_status_code).to eq(486)
expect(e.sip_status).to eq('Busy Here')
expect(e.to_s).to include('486').and include('Busy Here')
Expand Down
Loading