log warning if signal messages get dropped during reconnect - #1391
Open
lukasIO wants to merge 2 commits into
Open
log warning if signal messages get dropped during reconnect#1391lukasIO wants to merge 2 commits into
lukasIO wants to merge 2 commits into
Conversation
Contributor
Changeset ✓This PR includes a changeset covering all affected packages:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+1084
to
+1085
| let dbg = format!("{:?}", msg); | ||
| dbg.split(['(', ' ']).next().unwrap_or("Unknown").to_string() |
Contributor
There was a problem hiding this comment.
🟡 Large warnings can stall reconnection
When a dropped message is large, signal_message_variant_name formats its complete payload just to obtain the variant name. Bursts can block processing beyond the five-second deadline and force a full reconnect.
Prompt for agents
Replace the Debug-string parsing in livekit-signaling/src/lib.rs signal_message_variant_name with a bounded-cost way to identify each signal_response::Message variant without formatting nested payloads. Preserve useful variant names in the warning and add coverage for payload-heavy and scalar variants. Consider that get_reconnect_response reads from an unbounded channel under a five-second timeout, so naming a message must take constant work regardless of payload size.
Was this helpful? React with 👍 or 👎 to provide feedback.
1egoman
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.